| From: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: postgres_fdw insert batching |
| Date: | 2021-02-05 01:55:04 |
| Message-ID: | CAB8KJ=hCOF+88mxPzxT05i=DswbWXwcn-+zWij5-9eogcHu2Aw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2021年1月22日(金) 14:50 Ian Lawrence Barwick <barwick(at)gmail(dot)com>:
> Hi
>
> 2021年1月21日(木) 8:00 Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>:
>
>> OK, pushed after a little bit of additional polishing (mostly comments).
>>
>> Thanks everyone!
>>
>
> There's a minor typo in the doc's version of the ExecForeignBatchInsert()
> declaration;
> is:
>
> TupleTableSlot **
> ExecForeignBatchInsert(EState *estate,
> ResultRelInfo *rinfo,
> TupleTableSlot **slots,
> TupleTableSlot *planSlots,
> int *numSlots);
>
> should be:
>
> TupleTableSlot **
> ExecForeignBatchInsert(EState *estate,
> ResultRelInfo *rinfo,
> TupleTableSlot **slots,
> TupleTableSlot **planSlots,
> int *numSlots);
>
> (Trivial patch attached).
>
>
Forgot to mention the relevant doc link:
https://www.postgresql.org/docs/devel/fdw-callbacks.html#FDW-CALLBACKS-UPDATE
Regards
Ian Barwick
--
EnterpriseDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-02-05 02:17:48 | Re: Preserve attstattarget on REINDEX CONCURRENTLY |
| Previous Message | Ian Lawrence Barwick | 2021-02-05 01:54:15 | Re: POC: postgres_fdw insert batching |