Re: psql auto-completion for multiple where clauses

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql auto-completion for multiple where clauses
Date: 2010-07-16 15:04:27
Message-ID: af481f4c2ebc5e0c1ccf5eae713c4c90@biglumber.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

> Someone highlighed on IRC that after the first WHERE clause,
> autocomplete no longer works.
...
> SELECT * FROM tab_completion WHERE id = 2 AND s<tab><tab>
...
> Is there any chance of improving this so it would work for more than 1
> WHERE clause? I notice it also doesn't work for GROUP BY or HAVING at
> all, but seems to be fine for ORDER BY.

No: there is only a small number of words that we go back through,
so the above will not work as we cannot get back to the name of the table
from the right side of the AND. The way to fix that is to redesign our
tab-completion system such that it knows about a greater number of words,
perhaps even the complete statement.

> SELECT * FROM tab_completion WHERE id = 2 AND b<tab>
>
> Since there is no column beginning with "b", it might be an idea to
> get it to match "bark bark" instead. It might help alleviate what may
> be a gotcha for some.

This one is more doable, assuming we are really talking about:

SELECT * FROM tab_completion WHERE b<tab>

Keep in mind it will show up in a list if you do the following:

SELECT * FROM tab_completion WHERE <tab>

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
End Point Corporation http://www.endpoint.com/
PGP Key: 0x14964AC8 201007161102
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iEYEAREDAAYFAkxAdOkACgkQvJuQZxSWSsiMpACgvheNYe35eXugYQrR3fZ7AYl2
ZWoAnAwzDPREKuxrJzZK45TpInUCh03w
=E6eG
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2010-07-16 15:11:35 Re: dividing money by money
Previous Message Tom Lane 2010-07-16 14:43:16 Re: dividing money by money