Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Date: 2023-12-01 14:04:19
Message-ID: ae3b453e-a6be-3b9f-a8fe-a885d5d2795c@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 2023-11-29 We 07:20, Andrew Dunstan wrote:
>
> On 2023-11-28 Tu 21:28, Andres Freund wrote:
>> Hi,
>>
>> On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
>>> On 2023-11-20 Mo 20:53, Andres Freund wrote:
>>>> meson: docs: Add {html,man} targets, rename install-doc-*
>>>>
>>>> We have toplevel html, man targets in the autoconf build as well.
>>>> It'd be odd
>>>> to have an 'html' target but have the install target be
>>>> 'install-doc-html',
>>>> thus rename the install targets to match.
>>>
>>> This commit of one of its nearby friends appears to have broken
>>> crake's docs
>>> build:
>>>
>>> ERROR: Can't invoke target `html`: ambiguous name.Add target type
>>> and/or path:
>>> - ./doc/src/sgml/html:custom
>>> - ./doc/src/sgml/html:alias
>>>
>>> See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04>
>>>
>> Ah, I realize now that this is from meson compile html, not 'ninja
>> html'. That
>> explains why I couldn't reproduce this initially and why CI didn't
>> complain.
>> I don't really understand why meson compile complains in this case. 
>> I assume
>> you don't want to disambiguate as suggested, by building html:alias
>> instead?
>>
>
> I've done that as a temporary fix to get crake out of the hole, but
> it's pretty ugly, and I don't want to do it in a release if at all
> possible.

and doing this has broken the docs build for release 16.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-12-01 15:31:52 pgsql: Check collation when creating partitioned index
Previous Message Daniel Gustafsson 2023-12-01 12:52:52 Re: pgsql: Clean up role created in new subscription test.

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Verite 2023-12-01 14:59:22 Re: EXCLUDE COLLATE in CREATE/ALTER TABLE document
Previous Message Karl O. Pinc 2023-12-01 14:00:39 Re: Various small doc improvements; plpgsql, schemas, permissions, oidvector