Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Date: 2023-11-29 12:20:59
Message-ID: 703110e4-b495-e409-26a5-28e9fca8f3a5@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 2023-11-28 Tu 21:28, Andres Freund wrote:
> Hi,
>
> On 2023-11-23 08:32:21 -0500, Andrew Dunstan wrote:
>> On 2023-11-20 Mo 20:53, Andres Freund wrote:
>>> meson: docs: Add {html,man} targets, rename install-doc-*
>>>
>>> We have toplevel html, man targets in the autoconf build as well. It'd be odd
>>> to have an 'html' target but have the install target be 'install-doc-html',
>>> thus rename the install targets to match.
>>
>> This commit of one of its nearby friends appears to have broken crake's docs
>> build:
>>
>> ERROR: Can't invoke target `html`: ambiguous name.Add target type and/or path:
>> - ./doc/src/sgml/html:custom
>> - ./doc/src/sgml/html:alias
>>
>> See<https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2023-11-23%2012%3A52%3A04>
> Ah, I realize now that this is from meson compile html, not 'ninja html'. That
> explains why I couldn't reproduce this initially and why CI didn't complain.
> I don't really understand why meson compile complains in this case. I assume
> you don't want to disambiguate as suggested, by building html:alias instead?
>

I've done that as a temporary fix to get crake out of the hole, but it's
pretty ugly, and I don't want to do it in a release if at all possible.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-11-29 13:49:52 Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Previous Message Thomas Munro 2023-11-29 04:32:26 pgsql: Optimize pg_readv/pg_pwritev single vector case.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-11-29 12:37:53 Re: remaining sql/json patches
Previous Message Dilip Kumar 2023-11-29 11:28:07 Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock