| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Possible regression setting GUCs on \connect |
| Date: | 2023-04-27 18:47:33 |
| Message-ID: | ae319e70-de53-d167-43a0-acccfceba19e@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/27/23 21:43, Nathan Bossart wrote:
> I suspect the problem is that GUCArrayDelete() is using the wrong Datum:
>
> diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
> index 9dd624b3ae..ee9f87e7f2 100644
> --- a/src/backend/utils/misc/guc.c
> +++ b/src/backend/utils/misc/guc.c
> @@ -6496,7 +6496,7 @@ GUCArrayDelete(ArrayType *array, ArrayType **usersetArray, const char *name)
> {
> newarray = construct_array_builtin(&d, 1, TEXTOID);
> if (usersetArray)
> - newUsersetArray = construct_array_builtin(&d, 1, BOOLOID);
> + newUsersetArray = construct_array_builtin(&userSetDatum, 1, BOOLOID);
> }
>
> index++;
That seems to work. The errors are now gone.
Thanks!
-David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-04-27 18:51:28 | Re: Possible regression setting GUCs on \connect |
| Previous Message | Nathan Bossart | 2023-04-27 18:43:08 | Re: Possible regression setting GUCs on \connect |