Re: Possible regression setting GUCs on \connect

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Possible regression setting GUCs on \connect
Date: 2023-04-27 18:43:08
Message-ID: 20230427184308.GA1812411@nathanxps13
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I suspect the problem is that GUCArrayDelete() is using the wrong Datum:

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 9dd624b3ae..ee9f87e7f2 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -6496,7 +6496,7 @@ GUCArrayDelete(ArrayType *array, ArrayType **usersetArray, const char *name)
{
newarray = construct_array_builtin(&d, 1, TEXTOID);
if (usersetArray)
- newUsersetArray = construct_array_builtin(&d, 1, BOOLOID);
+ newUsersetArray = construct_array_builtin(&userSetDatum, 1, BOOLOID);
}

index++;

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2023-04-27 18:47:33 Re: Possible regression setting GUCs on \connect
Previous Message Robert Haas 2023-04-27 18:30:04 Re: can system catalogs have GIN indexes?