| From: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org>, Sehrope Sarkuni <sehrope(at)jackdb(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
| Subject: | Re: Improve UX of YUM/DNF download form |
| Date: | 2020-06-09 12:27:43 |
| Message-ID: | ae207206-5c8c-21d5-3eb8-6dfb75bca7e5@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
On 6/9/20 7:58 AM, Dave Page wrote:
> So here's the updated patch following some discussion with Magnus:
>
> - Make the copyScript function more generic so it can be used elsewhere.
> - Don't include comments and blank lines in the copied text.
> - Move the css into main.css.
> - Add the actual install step to the Debian/Ubuntu instructions.
> - Improve naming of vars, classes, ids etc.
> - Ensure the copyScript function works fine with < > and so-on in the
> script.
That certainly changed a lot overnight ;)
LGTM. I don't have any additional comments on it, so I will give a +1.
Jonathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2020-06-09 12:31:44 | Re: Improve UX of YUM/DNF download form |
| Previous Message | Dave Page | 2020-06-09 11:58:25 | Re: Improve UX of YUM/DNF download form |