| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Cc: | Sehrope Sarkuni <sehrope(at)jackdb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
| Subject: | Re: Improve UX of YUM/DNF download form |
| Date: | 2020-06-09 12:31:44 |
| Message-ID: | CA+OCxowkK03Zz1Lcv9avS9=SKtJJVU8pKaZwcEPiqwkw9DiAFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
On Tue, Jun 9, 2020 at 1:27 PM Jonathan S. Katz <jkatz(at)postgresql(dot)org>
wrote:
> On 6/9/20 7:58 AM, Dave Page wrote:
> > So here's the updated patch following some discussion with Magnus:
> >
> > - Make the copyScript function more generic so it can be used elsewhere.
> > - Don't include comments and blank lines in the copied text.
> > - Move the css into main.css.
> > - Add the actual install step to the Debian/Ubuntu instructions.
> > - Improve naming of vars, classes, ids etc.
> > - Ensure the copyScript function works fine with < > and so-on in the
> > script.
>
> That certainly changed a lot overnight ;)
>
> LGTM. I don't have any additional comments on it, so I will give a +1.
>
Thanks. Any thoughts on the server vs. client thing?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2020-06-10 13:09:48 | Re: Improve UX of YUM/DNF download form |
| Previous Message | Jonathan S. Katz | 2020-06-09 12:27:43 | Re: Improve UX of YUM/DNF download form |