Re: [PATCH] Negative Transition Aggregate Functions (WIP)

On Thu, January 2, 2014 13:36, Erik Rijkers wrote:
> On Thu, January 2, 2014 13:05, David Rowley wrote:
>> here's a slightly updated patch
>> [inverse_transition_functions_v1.8.patch.gz ]
>
> patch applies, and compiles (although with new warnings).
> But make check complains loudly: see attached.
>
> warnings:

The TRACE_POSTGRESQL_SORT_DONE warnings were not from your patch; sorry about that. They occur on HEAD too (with a debug
compile).

tuplesort.c:935:44: warning: comparison between pointer and integer [enabled by default]
TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
^
tuplesort.c:935:2: note: in expansion of macro â
TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);

The 'make check' failure remains a problem

The output I sent earlier today was for this configure:

./configure --prefix=/var/data1/pg_stuff/pg_installations/pgsql.inverse --with-pgport=6594 \
--bindir=/var/data1/pg_stuff/pg_installations/pgsql.inverse/bin \
--libdir=/var/data1/pg_stuff/pg_installations/pgsql.inverse/lib \
--quiet --enable-depend --enable-cassert --enable-debug --with-perl \
--with-openssl --with-libxml --enable-dtrace

(and that's still repeatable)

Perhaps this helps:

with another configure:

./configure --prefix=/var/data1/pg_stuff/pg_installations/pgsql.inverse --with-pgport=6594
--bindir=/var/data1/pg_stuff/pg_installations/pgsql.inverse/bin.fast
--libdir=/var/data1/pg_stuff/pg_installations/pgsql.inverse/lib.fast --quiet --enable-depend --with-perl --with-openssl
--with-libxml

I get only this single 'make check' error:

*** /var/data1/pg_stuff/pg_sandbox/pgsql.inverse/src/test/regress/expected/window.out 2014-01-02 16:19:48.000000000 +0100
--- /var/data1/pg_stuff/pg_sandbox/pgsql.inverse/src/test/regress/results/window.out 2014-01-02 16:21:43.000000000 +0100
***************
*** 1188,1195 ****
sum
------
6.01
! 5
! 3
(3 rows)

SELECT i,COUNT(v) OVER (ORDER BY i ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING)
--- 1188,1195 ----
sum
------
6.01
! 5.00
! 3.00
(3 rows)

SELECT i,COUNT(v) OVER (ORDER BY i ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING)

======================================================================

Centos 5.7
gcc 4.8.2

Thanks; and Happy New Year

Erik Rijkers