| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Erik Rijkers" <er(at)xs4all(dot)nl> |
| Cc: | "David Rowley" <dgrowleyml(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |
| Date: | 2014-01-02 19:10:17 |
| Message-ID: | 10350.1388689817@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Erik Rijkers" <er(at)xs4all(dot)nl> writes:
> The TRACE_POSTGRESQL_SORT_DONE warnings were not from your patch; sorry about that. They occur on HEAD too (with a debug
> compile).
> tuplesort.c:935:44: warning: comparison between pointer and integer [enabled by default]
> TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
> ^
> tuplesort.c:935:2: note: in expansion of macro
> TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
FWIW, I don't see any such warnings on either of the machines I have that
will accept --enable-dtrace. state->tapeset is a pointer, so these
warnings look a tad bogus.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-01-02 19:12:45 | Re: more psprintf() use |
| Previous Message | Tom Lane | 2014-01-02 19:03:32 | Re: preserving forensic information when we freeze |