Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL
Date: 2024-05-04 15:06:45
Message-ID: ad1dd526-3537-441b-9966-f5fdb710f000@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 03/05/2024 11:44, Daniel Gustafsson wrote:
>> On 2 May 2024, at 12:30, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> On 02/05/2024 13:24, Daniel Gustafsson wrote:
>
>>> This makes targeting 7.0 as the lowest LibreSSL version appealing in my
>>> patchset for removing support for old OpenSSL and LibreSSL versions.
>>
>> Works for me. Although there's little harm in keeping the "#ifdef SSL_AD_NO_APPLICATION_PROTOCOL" either, if that's the only thing missing from 6.9.
>
> In the meantime I'll apply the below to keep the comment correct and to help
> future-me when revisiting SSL library support =)
>
> - * OpenSSL 1.1.0 and later, but as of this writing not in LibreSSL.
> + * OpenSSL 1.1.0 and later, as well as in LibreSSL 3.4.3 (OpenBSD 7.0) and
> + * later.
>
> Any objections to that?

Sounds good

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2024-05-05 00:55:12 pgsql: Fix query pullup issue with WindowClause runCondition
Previous Message Tom Lane 2024-05-03 18:10:51 pgsql: First-draft release notes for 16.3.