Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL
Date: 2024-05-03 08:44:39
Message-ID: 331BA556-4AAD-4B09-B86B-A5947F248E3F@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 2 May 2024, at 12:30, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> On 02/05/2024 13:24, Daniel Gustafsson wrote:

>> This makes targeting 7.0 as the lowest LibreSSL version appealing in my
>> patchset for removing support for old OpenSSL and LibreSSL versions.
>
> Works for me. Although there's little harm in keeping the "#ifdef SSL_AD_NO_APPLICATION_PROTOCOL" either, if that's the only thing missing from 6.9.

In the meantime I'll apply the below to keep the comment correct and to help
future-me when revisiting SSL library support =)

- * OpenSSL 1.1.0 and later, but as of this writing not in LibreSSL.
+ * OpenSSL 1.1.0 and later, as well as in LibreSSL 3.4.3 (OpenBSD 7.0) and
+ * later.

Any objections to that?

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-05-03 09:15:50 pgsql: Fix segmentation fault in MergeInheritedAttribute()
Previous Message Tom Lane 2024-05-02 21:36:40 pgsql: Throw a more on-point error for publications depending on column