| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira <euler(at)eulerto(dot)com>, chenjq(dot)jy(at)fujitsu(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command |
| Date: | 2021-08-27 11:21:52 |
| Message-ID: | aa186eac-2701-210a-bbf1-3e1bec945e23@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 20.08.21 12:49, Daniel Gustafsson wrote:
>> On 19 Aug 2021, at 04:45, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>>
>> On Thu, Aug 19, 2021 at 2:53 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>>
>>>> On 18 Aug 2021, at 15:49, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>>>
>>>> Since there is consensus for removing --quiet, I’ll propose a patch in a bit
>>>> for removing it and fixing up the tests.
>>>
>>> Turns I was a bit undercaffeinated when skimming the tests, it really wasn’t
>>> that invasive. The attached diff removes --quiet and fixes up the tests and
>>> docs to match. Anyone who wants to keep --quiet should.. ehm, not keep quiet.
>>
>> The patch looks good to me.
>
> Applied to master and 14, thanks for review!
I see that we still have the PQsetErrorVerbosity() call for --verbose,
and we still issue warnings with --no-strict-names. Did we want to keep
these two behaviors?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-08-27 12:02:10 | Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command |
| Previous Message | Peter Eisentraut | 2021-08-27 10:36:04 | Re: BUG #17158: Distinct ROW fails with Postgres 14 |