Re: BUG #17148: About --no-strict-names option and --quiet option of pg_amcheck command

> On 27 Aug 2021, at 13:21, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 20.08.21 12:49, Daniel Gustafsson wrote:
>>> On 19 Aug 2021, at 04:45, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>>>
>>> On Thu, Aug 19, 2021 at 2:53 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>>>
>>>>> On 18 Aug 2021, at 15:49, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>>>>
>>>>> Since there is consensus for removing --quiet, I’ll propose a patch in a bit
>>>>> for removing it and fixing up the tests.
>>>>
>>>> Turns I was a bit undercaffeinated when skimming the tests, it really wasn’t
>>>> that invasive. The attached diff removes --quiet and fixes up the tests and
>>>> docs to match. Anyone who wants to keep --quiet should.. ehm, not keep quiet.
>>>
>>> The patch looks good to me.
>> Applied to master and 14, thanks for review!
>
> I see that we still have the PQsetErrorVerbosity() call for --verbose, and we still issue warnings with --no-strict-names. Did we want to keep these two behaviors?

I think issuing the warnings for --no-strict-names is appropriate, setting
PQsetErrorVerbosity on --verbose might be less so although I don’t strong
feelings on that. Maybe setting that should be reserved for the extra verbose
levels (that many other projects have with -vv etc) if we ever add that?

--
Daniel Gustafsson https://vmware.com/