Re: More business with $Test::Builder::Level in the TAP tests

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More business with $Test::Builder::Level in the TAP tests
Date: 2021-10-06 08:24:29
Message-ID: a9f99d81-e457-eb54-9b1e-8c4ba2fc33da@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06.10.21 08:28, Michael Paquier wrote:
> Following up with Peter E's recent commit 73aa5e0 to add some
> forgotten level incrementations, I got to look again at what I did
> wrong and why this stuff is useful.
>
> I have gone through all the TAP tests and any code paths using
> subroutines, to note that we could improve the locations of the
> reports we get by adding more $Test::Builder::Level. The context is
> important, as some code paths use rather-long routines and also
> argument values that allow to track easily which test path is being
> taken (like pg_rewind), so there is no need to add anything in such
> places. The attached patch adds incrementations for the tests where
> the debugging becomes much easier if there is a failure.

These look correct to me.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2021-10-06 08:30:54 Re: RfC entries in CF 2021-09
Previous Message bt21tanigaway 2021-10-06 08:14:51 Re: Fix pg_log_backend_memory_contexts() 's delay