From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | More business with $Test::Builder::Level in the TAP tests |
Date: | 2021-10-06 06:28:24 |
Message-ID: | YV1CCFwgM1RV1LeS@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi all,
Following up with Peter E's recent commit 73aa5e0 to add some
forgotten level incrementations, I got to look again at what I did
wrong and why this stuff is useful.
I have gone through all the TAP tests and any code paths using
subroutines, to note that we could improve the locations of the
reports we get by adding more $Test::Builder::Level. The context is
important, as some code paths use rather-long routines and also
argument values that allow to track easily which test path is being
taken (like pg_rewind), so there is no need to add anything in such
places. The attached patch adds incrementations for the tests where
the debugging becomes much easier if there is a failure.
Thoughts?
--
Michael
Attachment | Content-Type | Size |
---|---|---|
tap-builder-level.patch | text/x-diff | 6.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2021-10-06 06:41:09 | Re: wrapping CF 2021-09 |
Previous Message | Peter Geoghegan | 2021-10-06 06:21:00 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |