| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH]Add tab completion for foreigh table |
| Date: | 2022-01-13 03:38:12 |
| Message-ID: | a915e3cd-39ab-f85a-ab94-bd345f258d68@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022/01/11 21:43, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
> Hi
>
> Attached a patch to improve the tab completion for foreigh table.
Thanks!
Isn't it better to tab-complete not only "PARTITION OF" but also "(" for CREATE FOREIGN TABLE?
> Also modified some DOC description of ALTER TABLE at [1] in according with CREATE INDEX at [2].
>
> In [1], we use "ALTER INDEX ATTACH PARTITION"
> In [2], we use "ALTER INDEX ... ATTACH PARTITION"
>
> I think the format in [2] is better.
Agreed.
IMO it's better to make the docs changes in separate patch because they are not directly related to the improvement of tab-completion.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Imseih (AWS), Sami | 2022-01-13 03:52:46 | Re: Add index scan progress to pg_stat_progress_vacuum |
| Previous Message | Julien Rouhaud | 2022-01-13 03:19:27 | Re: a misbehavior of partition row movement (?) |