| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [PATCH]Add tab completion for foreigh table |
| Date: | 2022-01-13 06:57:42 |
| Message-ID: | OS0PR01MB61138327FAE097FE71804660FB539@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, January 13, 2022 12:38 PM, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> Isn't it better to tab-complete not only "PARTITION OF" but also "(" for CREATE
> FOREIGN TABLE?
Thanks for your review. Left bracket completion added.
> IMO it's better to make the docs changes in separate patch because they are not
> directly related to the improvement of tab-completion.
Agreed. The former one patch was divided into two.
0001 patch, added tab completion for foreign table.
0002 patch, modified some doc description.
Regards,
Tang
| Attachment | Content-Type | Size |
|---|---|---|
| v-0001-add-tab-completion-for-PARTITION-OF-when-creating.patch | application/octet-stream | 2.3 KB |
| v2-0002-Modify-doc-description-for-ALTER-TABLE-in-accordi.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2022-01-13 07:00:00 | Re: Why is src/test/modules/committs/t/002_standby.pl flaky? |
| Previous Message | Peter Smith | 2022-01-13 06:49:20 | Re: row filtering for logical replication |