| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Consolidate ItemPointer to Datum conversion functions |
| Date: | 2023-02-13 09:26:58 |
| Message-ID: | a6a190a1-ec0b-6bcc-eb38-2aa5889bbd7d@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.02.23 09:33, Peter Eisentraut wrote:
> On 06.02.23 11:11, Heikki Linnakangas wrote:
>> On 06/02/2023 11:54, Peter Eisentraut wrote:
>>> Instead of defining the same set of macros several times, define it once
>>> in an appropriate header file. In passing, convert to inline functions.
>>
>> Looks good to me. Did you consider moving PG_GETARG_ITEMPOINTER and
>> PG_RETURN_ITEMPOINTER, too? They're only used in tid.c, but for most
>> datatypes, we define the PG_GETARG and PG_RETURN macros in the same
>> header file as the the Datum conversion functions.
>
> Yeah that makes sense. Here is an updated patch for that.
committed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-02-13 09:33:34 | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |
| Previous Message | Alvaro Herrera | 2023-02-13 09:07:52 | Re: Support logical replication of DDLs |