| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Consolidate ItemPointer to Datum conversion functions |
| Date: | 2023-02-09 08:33:16 |
| Message-ID: | 5f6ed461-331f-47b5-9ce2-90fc660d78f5@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06.02.23 11:11, Heikki Linnakangas wrote:
> On 06/02/2023 11:54, Peter Eisentraut wrote:
>> Instead of defining the same set of macros several times, define it once
>> in an appropriate header file. In passing, convert to inline functions.
>
> Looks good to me. Did you consider moving PG_GETARG_ITEMPOINTER and
> PG_RETURN_ITEMPOINTER, too? They're only used in tid.c, but for most
> datatypes, we define the PG_GETARG and PG_RETURN macros in the same
> header file as the the Datum conversion functions.
Yeah that makes sense. Here is an updated patch for that.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Consolidate-ItemPointer-to-Datum-conversion-funct.patch | text/plain | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2023-02-09 08:33:57 | Re: Exit walsender before confirming remote flush in logical replication |
| Previous Message | Fujii Masao | 2023-02-09 08:32:08 | Re: Is psSocketPoll doing the right thing? |