Re: [PATCH] Use $ parameters as replacement characters for pg_stat_statements

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Lukas Fittl <lukas(at)fittl(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Use $ parameters as replacement characters for pg_stat_statements
Date: 2017-03-01 14:51:53
Message-ID: a6538083-854a-9739-769d-3ada5de496dc@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/28/17 20:01, Lukas Fittl wrote:
> Currently pg_stat_statements replaces constant values with ? characters.
> I've seen this be a problem on multiple occasions, in particular since
> it conflicts with the use of ? as an operator.
>
> I'd like to propose changing the replacement character from ? to instead
> be a parameter (like $1).

Hmm, I think this could confuse people into thinking that the queries
displayed were in fact prepared queries.

Maybe we could gather some more ideas.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-03-01 15:06:23 Re: Possible spelling fixes
Previous Message Alvaro Herrera 2017-03-01 14:51:36 Re: objsubid vs subobjid