| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Josh Soref <jsoref(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Possible spelling fixes |
| Date: | 2017-03-01 15:06:23 |
| Message-ID: | 20170301150623.urjlpjmd3svqlo3d@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Josh Soref wrote:
> - else if (ControlFile->state == DB_SHUTDOWNING)
> + else if (ControlFile->state == DB_SHUTTINGDOWN)
SHUTDOWNING and SHUTDOWNED are typos first introduced by hacker emeritus
Vadim Mikheev in 1999 together with WAL, commit 47937403676d. It goes
to show that not every PG hacker is a learned English speaker. I see no
reason to change the spelling.
> - List *epq_arowmarks;
> + List *epq_arowMarks;
I'd not change this one either. Of the large set of words run together
in our source, this is one of the easiest ones to read.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-03-01 15:09:10 | Re: Possible spelling fixes |
| Previous Message | Peter Eisentraut | 2017-03-01 14:51:53 | Re: [PATCH] Use $ parameters as replacement characters for pg_stat_statements |