Re: pgsql: Allow building with MSVC and Strawberry perl

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow building with MSVC and Strawberry perl
Date: 2022-11-25 23:56:02
Message-ID: a618e87b-2bdd-f00a-20f6-9f7e0651aa72@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 2022-11-25 Fr 18:48, Andres Freund wrote:
> Hi,
>
> On 2022-11-25 15:33:31 -0800, Andres Freund wrote:
>> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with
>> #define __builtin_expect(expr, val) (expr)
> And it does so with src/tools/msvc as well. I think we might need a
> preprocessed plperl.c from drongo to analyze this further.
>
> There might be some unrelated under-specified build issues, I get weird errors
> if I start by building plperl.vcxproj, without first having built
> postgres.vcxproj. But ...
>

Yeah, drongo builds fine too. It's the handshake thing that's the
current issue. I'll see if forcing -DNO_THREAD_SAFE_LOCALE works.

Thanks

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-11-26 00:22:15 Re: pgsql: Allow building with MSVC and Strawberry perl
Previous Message Andres Freund 2022-11-25 23:48:13 Re: pgsql: Allow building with MSVC and Strawberry perl