Re: pgsql: Allow building with MSVC and Strawberry perl

Hi,

On 2022-11-25 18:56:02 -0500, Andrew Dunstan wrote:
> On 2022-11-25 Fr 18:48, Andres Freund wrote:
> > On 2022-11-25 15:33:31 -0800, Andres Freund wrote:
> >> FWIW a meson build with msvc 2019 and strawberry perl 5.32 builds fine with
> >> #define __builtin_expect(expr, val) (expr)
> > And it does so with src/tools/msvc as well. I think we might need a
> > preprocessed plperl.c from drongo to analyze this further.
> >
> > There might be some unrelated under-specified build issues, I get weird errors
> > if I start by building plperl.vcxproj, without first having built
> > postgres.vcxproj. But ...
> >
>
>
> Yeah, drongo builds fine too.

Oh - I just looked at HEAD, where it fails in the 'make' stage on the BF. But
I now see the PLCheck-C failures in the older branches.

> It's the handshake thing that's the current issue. I'll see if forcing
> -DNO_THREAD_SAFE_LOCALE works.

With it tests do pass for me with meson + msvc + perl 5.32.

Greetings,

Andres Freund