Re: Can we avoid chdir'ing in resolve_symlinks() ?

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Can we avoid chdir'ing in resolve_symlinks() ?
Date: 2022-09-12 19:48:47
Message-ID: a4f73e5c-60ba-7fc2-252b-29bc946cee7e@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12.09.22 17:33, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> On 02.09.22 01:39, Tom Lane wrote:
>>> find_my_exec() wants to obtain an absolute, symlink-free path
>>> to the program's own executable, for what seem to me good
>>> reasons.
>
>> I still think they are bad reasons, and we should kill all that code.
>> Just sayin' ...
>
> Are you proposing we give up the support for relocatable installations?
> I'm not here to defend that feature, but I bet somebody will. (And
> doesn't "make check" depend on it?)

I'm complaining specifically about the resolving of symlinks. Why does

$ /usr/local/opt/postgresql(at)13/bin/pg_config --bindir

print

/usr/local/Cellar/postgresql(at)13/13.8/bin

when it clearly should print

/usr/local/opt/postgresql(at)13/bin

This is unrelated to the support for relocatable installations, AFAICT.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2022-09-12 19:52:28 Re: PostgreSQL 15 release announcement draft
Previous Message Tom Lane 2022-09-12 19:46:10 Re: Splitting up guc.c