Re: Can we avoid chdir'ing in resolve_symlinks() ?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Can we avoid chdir'ing in resolve_symlinks() ?
Date: 2022-09-12 20:07:19
Message-ID: 1776365.1663013239@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 12.09.22 17:33, Tom Lane wrote:
>> Are you proposing we give up the support for relocatable installations?
>> I'm not here to defend that feature, but I bet somebody will. (And
>> doesn't "make check" depend on it?)

> I'm complaining specifically about the resolving of symlinks. Why does

> $ /usr/local/opt/postgresql(at)13/bin/pg_config --bindir
> print
> /usr/local/Cellar/postgresql(at)13/13.8/bin
> when it clearly should print
> /usr/local/opt/postgresql(at)13/bin

I'm not sure about your setup there, but if you mean that
/usr/local/opt/postgresql(at)13/bin is a symlink reading more or less
"./13.8/bin", I doubt that failing to canonicalize that is a good idea.
The point of finding the bindir is mainly to be able to navigate to its
sibling directories such as lib/, etc/, share/. There's no certainty
that a symlink leading to the bin directory will have sibling symlinks
to those other directories.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dagfinn Ilmari Mannsåker 2022-09-12 20:12:03 Re: Splitting up guc.c
Previous Message Heikki Linnakangas 2022-09-12 20:04:10 Re: preserve timestamps when installing headers