| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> | 
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> | 
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> | 
| Subject: | Re: Remove MSVC scripts from the tree | 
| Date: | 2023-12-20 07:31:01 | 
| Message-ID: | a25d6285-066b-4d68-a53e-af1d5647aff0@eisentraut.org | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
On 19.12.23 17:44, Nazir Bilal Yavuz wrote:
> I think we need to require sed when dtrace or selinux is found, not by
> looking at the return value of the get_option().enabled().
Right. I think the correct condition would be
sed = find_program(get_option('SED'), 'sed', native: true,
                    required: dtrace.found() or selinux.found())
I was trying to avoid that because it would require moving the 
find_program() to somewhere later in the top-level meson.build, but I 
suppose we have to do it that way.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-12-20 07:36:53 | Re: Remove MSVC scripts from the tree | 
| Previous Message | Drouvot, Bertrand | 2023-12-20 07:16:09 | Re: Function to get invalidation cause of a replication slot. |