From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | gurjeet(at)singh(dot)im, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Standardize type of variable when extending Buffers |
Date: | 2023-09-19 08:07:49 |
Message-ID: | a22e45e6-3ddb-a4f9-dbe2-1262582f48e5@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 10.07.23 13:08, Ranier Vilela wrote:
>
> Em seg., 10 de jul. de 2023 às 03:27, Kyotaro Horiguchi
> <horikyota(dot)ntt(at)gmail(dot)com <mailto:horikyota(dot)ntt(at)gmail(dot)com>> escreveu:
>
> At Fri, 7 Jul 2023 11:29:16 -0700, Gurjeet Singh <gurjeet(at)singh(dot)im
> <mailto:gurjeet(at)singh(dot)im>> wrote in
> > On Fri, Jul 7, 2023 at 6:12 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com
> <mailto:ranier(dot)vf(at)gmail(dot)com>> wrote:
> > >
> > > Hi,
> > >
> > > This has already been discussed in [1].
> > > But I thought it best to start a new thread.
> > >
> > > The commit 31966b1 introduced the infrastructure to extend
> > > buffers.
> > > But the patch mixed types with int and uint32.
> > > The correct type of the variable counter is uint32.
> > >
> > > Fix by standardizing the int type to uint32.
> > >
> > > patch attached.
> >
> > LGTM.
>
> LGTM, too.
>
> Thanks Gurjeet and Kyotaro, for taking a look.
committed
From | Date | Subject | |
---|---|---|---|
Next Message | Andrey Lepikhov | 2023-09-19 08:21:15 | Re: [PoC] Reducing planning time when tables have many partitions |
Previous Message | Sergey Shinderuk | 2023-09-19 08:06:25 | Re: Fix error handling in be_tls_open_server() |