From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | jian he <jian(dot)universality(at)gmail(dot)com> |
Cc: | Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: minor doc issue in 9.16.2.1.1. Boolean Predicate Check Expressions |
Date: | 2024-11-20 22:04:37 |
Message-ID: | Zz5c9Xn_omTeWdtv@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Nov 5, 2024 at 05:24:07PM +0800, jian he wrote:
> On Thu, Oct 31, 2024 at 11:51 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >
> > On Fri, Oct 18, 2024 at 10:00:54AM +0800, jian he wrote:
> > > On Fri, Oct 18, 2024 at 2:05 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > > > Yes, updated patch attached.
> > > >
> > > looks good.
> > >
> > > in the meantime, do you think it's necessary to slightly rephrase
> > > jsonb_path_match doc entry:
> > >
> > > currently doc entry:
> > > jsonb_path_match ( target jsonb, path jsonpath [, vars jsonb [, silent
> > > boolean ]] ) → boolean
> > > Returns the result of a JSON path predicate check for the specified JSON value.
> > >
> > >
> > > "the result of a JSON path predicate check for the specified JSON
> > > value." is a jsonb boolean.
> > > but jsonb_path_match returns sql boolean.
> > > maybe add something to describe case like: "if JSON path predicate
> > > check return jsonb null, jsonb_path_match will return SQL null".
> >
> > Yes, I think that is a good point, updated patch attached.
> >
>
> played with
> https://www.postgresql.org/docs/current/functions-json.html#FUNCTIONS-SQLJSON-FILTER-EX-TABLE
>
> The patch looks good to me.
Patch applied back to PG 17.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2024-11-20 22:09:29 | Re: wrong comment in libpq.h |
Previous Message | Vik Fearing | 2024-11-20 21:54:23 | Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE |