| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: per backend I/O statistics |
| Date: | 2024-11-20 14:10:23 |
| Message-ID: | Zz3tzy0LJtHXjdmc@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, Nov 14, 2024 at 03:31:51PM +0900, Michael Paquier wrote:
> + /*
> + * Do serialize or not this kind of stats.
> + */
> + bool to_serialize:1;
>
> Not sure that "serialize" is the best term that applies here. For
> pgstats entries, serialization refers to the matter of writing their
> entries with a "serialized" name because they have an undefined number
> when stored locally after a reload. I'd suggest to split this concept
> into its own patch, rename the flag as "write_to_file"
Yeah, also this could useful for custom statistics. So I created a dedicated
thread and a patch proposal (see [1]).
[1]: https://www.postgresql.org/message-id/Zz3skBqzBncSFIuY%40ip-10-97-1-34.eu-west-3.compute.internal
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marcos Pegoraro | 2024-11-20 14:14:55 | Re: proposal: schema variables |
| Previous Message | Bertrand Drouvot | 2024-11-20 14:05:04 | Add a write_to_file member to PgStat_KindInfo |