Re: doc issues in event-trigger-matrix.html

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: doc issues in event-trigger-matrix.html
Date: 2024-10-29 22:33:57
Message-ID: ZyFi1QHnBwuo0BQv@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 29, 2024 at 03:53:43PM +0100, Daniel Gustafsson wrote:
> +1, I think this is a net improvement.

Agreed. I have spent some time looking in the past few years looking
at patches that tweaked this table, and it was always hard to figure
out if it was completely right.

> The only thing I would change on top of this is move the reference to section
> 9.30 under table_rewrite to be at the end after both supporting functions since
> the link is relevant to both of them. Something like:
>
> - <literal>pg_event_trigger_table_rewrite_oid()</literal> (see
> - <xref linkend="functions-event-triggers"/>). To discover the reason(s)
> - for the rewrite, use the function
> - <literal>pg_event_trigger_table_rewrite_reason()</literal>.
> + <literal>pg_event_trigger_table_rewrite_oid()</literal> To discover the reason(s)
> + for the rewrite, use the function <literal>pg_event_trigger_table_rewrite_reason()</literal>
> + (see <xref linkend="functions-event-triggers"/>).

Fine by me to tweak this paragraph like that with the link at the end.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2024-10-29 23:47:06 Re: detoast datum into the given buffer as a optimization.
Previous Message Jim Nasby 2024-10-29 22:23:55 Re: Vacuum statistics