Re: doc issues in event-trigger-matrix.html

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: doc issues in event-trigger-matrix.html
Date: 2024-10-29 14:53:43
Message-ID: FAF90BF5-3538-4ED3-A56B-4ADA2AB80245@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 29 Oct 2024, at 12:54, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> I made a patch for this. I have expanded the narrative discussion on what commands are supported for event triggers, also made a few corrections/additions there, based on inspecting the source code. And then removed the big matrix, which doesn't provide any additional information, I think.
>
> I think this is sufficient and covers everything. The only hand-wavy thing I can see is exactly which ALTER commands trigger the sql_drop event. But this was already quite imprecise before, and I think also not quite correct. This might need a separate investigation.
>
> In any case, we can use this as a starting point to iterate on the right wording etc.

+1, I think this is a net improvement.

The only thing I would change on top of this is move the reference to section
9.30 under table_rewrite to be at the end after both supporting functions since
the link is relevant to both of them. Something like:

- <literal>pg_event_trigger_table_rewrite_oid()</literal> (see
- <xref linkend="functions-event-triggers"/>). To discover the reason(s)
- for the rewrite, use the function
- <literal>pg_event_trigger_table_rewrite_reason()</literal>.
+ <literal>pg_event_trigger_table_rewrite_oid()</literal> To discover the reason(s)
+ for the rewrite, use the function <literal>pg_event_trigger_table_rewrite_reason()</literal>
+ (see <xref linkend="functions-event-triggers"/>).

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-10-29 15:00:28 Re: Reduce one comparison in binaryheap's sift down
Previous Message Andres Freund 2024-10-29 14:51:57 Re: Enhancing Memory Context Statistics Reporting