| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Li, Yong" <yoli(at)ebay(dot)com> |
| Cc: | Sutou Kouhei <kou(at)clear-code(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, "Debnath, Shawn" <sdn(at)ebay(dot)com>, "Shyrabokau, Anton" <antons(at)ebay(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Separate HEAP WAL replay logic into its own file |
| Date: | 2024-09-12 05:39:11 |
| Message-ID: | ZuJ-f42eoWvMlH0C@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 12, 2024 at 08:12:30AM +0900, Michael Paquier wrote:
> It looks like my mind was wondering away when I wrote this part.
> Sorry for the useless noise.
I was looking at all that, and this is only moving code around. While
the part for heap_xlog_logical_rewrite in rewriteheap.c is a bit sad
but historical, the header cleanup in heapam.c is nice.
Seeing heap_execute_freeze_tuple in heapam.h due to the dependency to
XLH_INVALID_XVAC and XLH_FREEZE_XVAC is slightly surprising, but the
opposite where heap_execute_freeze_tuple() would be in heapam_xlog.h
was less interesting. Just to say that I am agreeing with you here
and I have let this part as you suggested originally.
I was wondering for a bit about the order of the functions for heap
and heap, but these are ordered in their own, which is also OK. I
have added a few more comments at the top of each subroutine for the
records to be more consistent, and applied the result.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2024-09-12 06:10:44 | Re: Avoid dead code (contrib/pg_visibility/pg_visibility.c) |
| Previous Message | Peter Smith | 2024-09-12 05:30:23 | Re: Pgoutput not capturing the generated columns |