Re: Avoid dead code (contrib/pg_visibility/pg_visibility.c)

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid dead code (contrib/pg_visibility/pg_visibility.c)
Date: 2024-09-12 06:10:44
Message-ID: CAN55FZ2gABGjEeuiwxXX4Cj2L75YAFWMeHc2x=inje_VoFdVEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, 12 Sept 2024 at 08:19, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Sep 04, 2024 at 01:50:24PM -0300, Ranier Vilela wrote:
> > I think that commit c582b75
> > <https://github.com/postgres/postgres/commit/c582b75851c2d096ce050d753494505a957cee75>,
> > left an oversight.
> >
> > The report is:
> > CID 1559993: (#1 of 1): Logically dead code (DEADCODE)

Thanks for the report!

> I am not sure to understand what you mean here and if this is still
> relevant as of Noah's latest commit in 65c310b310a6.

This should be fixed in 65c310b310a6.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2024-09-12 06:31:01 Re: Accept invalidation messages before the query starts inside a transaction
Previous Message Michael Paquier 2024-09-12 05:39:11 Re: Separate HEAP WAL replay logic into its own file