Re: Remove emode argument from XLogFileRead/XLogFileReadAnyTLI

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Remove emode argument from XLogFileRead/XLogFileReadAnyTLI
Date: 2024-09-09 03:16:01
Message-ID: Zt5oce4KGmkOHRIW@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 06, 2024 at 08:10:43PM +0900, Yugo Nagata wrote:
> Since 1bb2558046c, XLogFileRead() doesn't use the emode argument.
> Also, since abf5c5c9a4f, XLogFileReadAnyTLI() is called just once
> and emode is always DEBUG2. So, I think we can remove the emode
> argument from these functions. I've atached the patch.

It's true that the last relevant caller of XLogFileReadAnyTLI() that
required an emode is abf5c5c9a4f1, as you say, that's also what I am
tracking down. Any objections to that?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-09-09 03:35:36 Re: Jargon and acronyms on this mailing list
Previous Message Peter Smith 2024-09-09 03:15:32 Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description