| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, vignesh C <vignesh21(at)gmail(dot)com>, Andrew Borodin <amborodin86(at)gmail(dot)com>, i(dot)lazarev(at)postgrespro(dot)ru, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Gilles Darold <gilles(at)darold(dot)net>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: MultiXact\SLRU buffers configuration |
| Date: | 2024-08-21 03:46:31 |
| Message-ID: | ZsVjFy7dNO3WKXaI@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 20, 2024 at 08:13:12PM -0400, Alvaro Herrera wrote:
> I don't understand what do the inj_stats_enabled stuff have to do with
> this patch. I suspect it's a git operation error, ie., you seem to have
> squashed two different things together.
Sorry, I should have split that for clarity (one patch for the GUC,
one to change the test to use CACHED/LOAD). It is not an error
though: if we don't have a controlled way to disable the stats of the
module, then the test would fail when calling the cached callback
because we'd try to allocate some memory for the dshash entry in
pgstats.
The second effect of initializing the shmem state of the module with
shared_preload_libraries is condition variables are set up for the
sake if the test, removing the dependency to the SQL load() call.
Both are OK, but I'd prefer introducing one use case for these two
macros in the tree, so as these can be used as a reference in the
future when developing new tests.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-08-21 04:29:06 | Re: Fix memory counter update in reorderbuffer |
| Previous Message | shveta malik | 2024-08-21 03:39:32 | Re: Conflict detection and logging in logical replication |