Re: remove volatile qualifiers from pg_stat_statements

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: remove volatile qualifiers from pg_stat_statements
Date: 2024-08-06 15:59:49
Message-ID: ZrJIdX7AMLxRPTwy@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 06, 2024 at 04:04:01PM +0900, Michael Paquier wrote:
> On Wed, Jul 31, 2024 at 07:01:38AM +0000, Bertrand Drouvot wrote:
>> I share the same understanding and I think those can be removed.
>>
>> The patch LGTM.
>
> That sounds about right. All the volatile references we have here
> have been kept under the assumption that a memory barrier is required.
> As we hold spin locks in these areas, that should not be necessary
> anyway. So LGTM as well.

Committed, thanks.

--
nathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2024-08-06 16:06:44 Re: Inconsistency with EXPLAIN ANALYZE CREATE MATERIALIZED VIEW
Previous Message Andres Freund 2024-08-06 15:58:37 Re: Support multi-column renaming?