| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Remove dependence on integer wrapping |
| Date: | 2024-07-24 03:20:50 |
| Message-ID: | ZqBzEucmgeib_6Fe@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 23, 2024 at 05:41:18PM -0400, Joseph Koshakow wrote:
> On Tue, Jul 23, 2024 at 2:14 AM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>> On Tue, Jul 23, 2024 at 6:56 AM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:
>>> The specific bug that this patch fixes is preventing the following
>>> statement:
>>>
>>> # INSERT INTO arroverflowtest(i[-2147483648:2147483647]) VALUES
> ('{1}');
>>>
>>> So we may want to add that test back in.
>>>
>> I agree with you.
>
> I've updated the patch to add this test back in.
I've committed/back-patched the fix for array_set_slice(). I ended up
fiddling with the test cases a bit more because they generate errors that
include a platform-dependent value (MaxArraySize). To handle that, I moved
the new tests to the section added in commit 18b5851 where VERBOSITY is set
to "sqlstate".
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-07-24 03:46:52 | Re: Logical Replication of sequences |
| Previous Message | Alexander Lakhin | 2024-07-24 03:00:00 | The 031_recovery_conflict.pl test might fail due to late pgstat entries flushing |