Re: [PATCH] Refactor pqformat.{c,h} and protocol.h

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] Refactor pqformat.{c,h} and protocol.h
Date: 2024-07-16 17:34:12
Message-ID: ZpavFHpMHdY9fJFc@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I took a closer look at 0001.

diff --git a/src/include/libpq/protocol.h b/src/include/libpq/protocol.h
index 4b8d440365..8c0f095edf 100644
--- a/src/include/libpq/protocol.h
+++ b/src/include/libpq/protocol.h
@@ -47,6 +47,7 @@
#define PqMsg_EmptyQueryResponse 'I'
#define PqMsg_BackendKeyData 'K'
#define PqMsg_NoticeResponse 'N'
+#define PqMsg_Progress 'P'
#define PqMsg_AuthenticationRequest 'R'
#define PqMsg_ParameterStatus 'S'
#define PqMsg_RowDescription 'T'

As discussed elsewhere [0], we can add the leader/worker protocol
characters to protocol.h, but they should probably go in a separate
section. I'd recommend breaking that part out to a separate patch, too.

[0] https://postgr.es/m/20230829161555.GB2136737%40nathanxps13

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2024-07-16 17:36:40 Re: Restrict EXPLAIN (ANALYZE) for RLS and security_barrier views
Previous Message Aleksander Alekseev 2024-07-16 17:21:50 Re: [PATCH] Refactor pqformat.{c,h} and protocol.h