Re: [PATCH] Refactor pqformat.{c,h} and protocol.h

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] Refactor pqformat.{c,h} and protocol.h
Date: 2024-07-16 18:14:35
Message-ID: CAJ7c6TMQNuUaJEYKtY-DNwZa-6yNTNUVsFR16yZLtB0iZZKx7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> As discussed elsewhere [0], we can add the leader/worker protocol
> characters to protocol.h, but they should probably go in a separate
> section. I'd recommend breaking that part out to a separate patch, too.

OK, here is the updated patchset. This time I chose not to include this patch:

> - Patch 3 rearranges the order of the functions in pqformat.{c,h} a
> bit to make the code easier to read.

... since arguably there is not much value in it. Please let me know
if you think it's actually needed.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v3-0001-Add-PqMsg_Progress-definition.patch application/octet-stream 2.0 KB
v3-0002-Always-pass-PqMsg_-to-pq_beginmessage-_reuse.patch application/octet-stream 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2024-07-16 18:57:10 Re: [18] Policy on IMMUTABLE functions and Unicode updates
Previous Message Nathan Bossart 2024-07-16 17:57:47 Re: Remove dependence on integer wrapping