| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ilya Gladyshev <ilya(dot)v(dot)gladyshev(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "李杰(慎追)" <adger(dot)lj(at)alibaba-inc(dot)com> |
| Subject: | Re: CREATE INDEX CONCURRENTLY on partitioned index |
| Date: | 2024-07-12 00:01:30 |
| Message-ID: | ZpByWlw0nJ1I_qr5@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 11, 2024 at 09:35:24PM +0100, Ilya Gladyshev wrote:
> It is broken in master, I just didn’t want to create a separate
> thread, but it can be fixed independently. As I remember, the
> problem is that progress is tracked for each table in the hierarchy
> as if the table is processed separately, without ever setting
> partitions_total and partitions_done counters.
Please let's move this point to its own thread and deal with it with
an independent patch. Hiding that in a thread that's already quite
long is not a good idea. This needs proper review, and a separate
thread with a good subject to describe the problem will attract a
better audience to deal with the problem you are seeing.
I was not paying much attention, until you've mentioned that this was
an issue with HEAD.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-07-12 00:38:30 | Re: Pluggable cumulative statistics |
| Previous Message | Noah Misch | 2024-07-11 23:52:09 | Re: Use read streams in CREATE DATABASE command when the strategy is wal_log |