| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Muhammad Ikram <mmikram(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: New standby_slot_names GUC in PG 17 |
| Date: | 2024-06-26 06:24:00 |
| Message-ID: | Znu0AME1Isc13Ly1@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 26, 2024 at 11:39:45AM +0530, Amit Kapila wrote:
> --- a/doc/src/sgml/release-17.sgml
> +++ b/doc/src/sgml/release-17.sgml
> @@ -1325,7 +1325,7 @@ Author: Michael Paquier <michael(at)paquier(dot)xyz>
>
> <!--
> Author: Amit Kapila <akapila(at)postgresql(dot)org>
> -2024-03-08 [bf279ddd1] Introduce a new GUC 'standby_slot_names'.
> +2024-03-08 [bf279ddd1] Introduce a new GUC 'synchronized_standby_slots'.
>
> I am not sure if it is a good idea to change release notes in the same
> commit as the code change. I would prefer to do it in a separate
> commit.
The existing commits referenced cannot change, but it's surely OK to
add a reference to the commit doing the rename for this item in the
release notes, and update the release notes to reflect the new GUC
name. Using two separate commits ensures that the correct reference
about the rename is added to the release notes, so that's the correct
thing to do, IMHO.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-06-26 06:42:30 | Re: New standby_slot_names GUC in PG 17 |
| Previous Message | Amit Kapila | 2024-06-26 06:09:45 | Re: New standby_slot_names GUC in PG 17 |