Re: New standby_slot_names GUC in PG 17

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Muhammad Ikram <mmikram(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: New standby_slot_names GUC in PG 17
Date: 2024-06-26 06:09:45
Message-ID: CAA4eK1+mvBpoKPz-3Td6LFUy6EHbouC300Te7-6iSui6tcBK+Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 26, 2024 at 10:19 AM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
>
> 2 ====
>
> Should we rename StandbySlotNamesConfigData too?
>

How about SyncStandbySlotsConfigData?

> 3 ====
>
> Should we rename SlotExistsInStandbySlotNames too?
>

Similarly SlotExistsInSyncStandbySlots?

> 4 ====
>
> Should we rename validate_standby_slots() too?
>

And validate_sync_standby_slots()?

--- a/doc/src/sgml/release-17.sgml
+++ b/doc/src/sgml/release-17.sgml
@@ -1325,7 +1325,7 @@ Author: Michael Paquier <michael(at)paquier(dot)xyz>

<!--
Author: Amit Kapila <akapila(at)postgresql(dot)org>
-2024-03-08 [bf279ddd1] Introduce a new GUC 'standby_slot_names'.
+2024-03-08 [bf279ddd1] Introduce a new GUC 'synchronized_standby_slots'.

I am not sure if it is a good idea to change release notes in the same
commit as the code change. I would prefer to do it in a separate
commit.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-06-26 06:24:00 Re: New standby_slot_names GUC in PG 17
Previous Message Daniel Gustafsson 2024-06-26 06:05:47 Re: Improve the connection failure error messages