Re: replace strtok()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: replace strtok()
Date: 2024-06-24 00:34:05
Message-ID: Zni-_fUq49SNSyir@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 22, 2024 at 11:48:21AM -0400, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> > On 18.06.24 13:43, Ranier Vilela wrote:
> >> I found another implementation of strsep, it seems lighter to me.
> >> I will attach it for consideration, however, I have not done any testing.
>
> > Yeah, surely there are many possible implementations. I'm thinking,
> > since we already took other str*() functions from OpenBSD, it makes
> > sense to do this here as well, so we have only one source to deal with.
>
> Why not use strpbrk? That's equally thread-safe, it's been there
> since C89, and it doesn't have the problem that you can't find out
> which of the delimiter characters was found.

Yeah, strpbrk() has been used in the tree as far as 2003 without any
port/ implementation.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2024-06-24 00:34:45 Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c)
Previous Message Ranier Vilela 2024-06-24 00:31:51 Re: Avoid incomplete copy string (src/backend/access/transam/xlog.c)