| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Jingxian Li <aqktjcm(at)qq(dot)com> |
| Subject: | Re: [PATCH] Fix bug when calling strncmp in check_authmethod_valid |
| Date: | 2024-05-14 05:12:38 |
| Message-ID: | ZkLyxju7_SDym-jU@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 13, 2024 at 01:01:21PM +0300, Aleksander Alekseev wrote:
>> Any objections to fixing this in 17 by removing it? (cc:ing Michael from the RMT)
>
> +1 Something that is not documented or used by anyone (apparently) and
> is broken should just be removed.
8a02339e9ba3 sounds like an argument good enough to prove there is no
demand in the field for being able to support options through initdb
--auth, and this does not concern only pam. If somebody is interested
in that, that could always be done later. My take is that this would
be simpler if implemented through a separate option, leaving the
checks between the options and the auth method up to the postmaster
when loading pg_hba.conf at startup.
Hence, no objections to clean up that now. Thanks for asking.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-05-14 05:33:46 | Re: SQL:2011 application time |
| Previous Message | Peter Smith | 2024-05-14 04:18:45 | Re: Slow catchup of 2PC (twophase) transactions on replica in LR |