Re: [PATCH] Fix bug when calling strncmp in check_authmethod_valid

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Jingxian Li <aqktjcm(at)qq(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] Fix bug when calling strncmp in check_authmethod_valid
Date: 2024-05-13 10:01:21
Message-ID: CAJ7c6TPR+CJ+SZZG0Q0+k+k5gGSci+-dx5zGEW7wqkXRJHNpjg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> Searching the archives I was unable to find any complaints, and this has been
> broken for the entire window of supported releases, so I propose we remove it
> as per the attached patch. If anyone is keen on making this work again for all
> the types where it makes sense, it can be resurrected (probably with a better
> implementation).
>
> Any objections to fixing this in 17 by removing it? (cc:ing Michael from the RMT)

+1 Something that is not documented or used by anyone (apparently) and
is broken should just be removed.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-05-13 10:11:11 Re: SQL:2011 application time
Previous Message Antonin Houska 2024-05-13 09:55:50 Re: UniqueKey v2