From: | Christoph Berg <myon(at)debian(dot)org> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: meson: Add initial version of meson based build system |
Date: | 2024-04-17 13:42:28 |
Message-ID: | Zh_RxBKH86OEsccE@msg.df7cb.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Re: Andres Freund
> https://git.postgresql.org/pg/commitdiff/e6927270cd18d535b77cbe79c55c6584351524be
This commit broke VPATH builds when the original source directory
contains symlinks.
The $PWD is /home/myon/postgresql/pg/master, but the actual directory
is /home/myon/projects/postgresql/pg/postgresql. When I
mkdir build; cd build && ../configure
there, I get a build directory missing a lot of files/directories:
$ ls build/
config.log config.status* GNUmakefile meson.build src/
$ ls build/src/
backend/ include/ interfaces/ Makefile.global Makefile.port@
$ ls build/src/backend/
port/
Given there are no other changes I think this bit is at fault:
> Modified Files
> --------------
> configure.ac | 6 +
+# Ensure that any meson build directories would reconfigure and see that
+# there's a conflicting in-tree build and can error out.
+if test "$vpath_build"="no"; then
+ touch meson.build
+fi
Christoph
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2024-04-17 14:20:31 | pgsql: Stabilize test of BRIN parallel create |
Previous Message | Peter Eisentraut | 2024-04-17 13:25:24 | pgsql: meson: Add some missing LLVM function checks |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-04-17 14:00:23 | Re: Speed up clean meson builds by ~25% |
Previous Message | Marcel Hofstetter | 2024-04-17 13:40:47 | Re: Solaris tar issues, or other reason why margay fails 010_pg_basebackup? |