pgsql: Stabilize test of BRIN parallel create

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Stabilize test of BRIN parallel create
Date: 2024-04-17 14:20:31
Message-ID: E1rx69G-002WHP-Kz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Stabilize test of BRIN parallel create

As explained in 4d916dd876, the test instability is caused by delayed
cleanup of deleted rows. This commit removes the DELETE, stabilizing the
test without accidentally disabling parallel builds.

The intent of the delete however was to produce empty ranges, and test
that the parallel index build populates those correctly. But there's
another way to create empty ranges - partial indexes, which does not
rely on cleanup of deleted rows.

Idea to use partial indexes by Matthias van de Meent, patch by me.

Discussion: https://postgr.es/m/95d9cd43-5a92-407c-b7e4-54cd303630fe%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0bd4b0689ba1f12fbbd9919ca76a71df3e7702a2

Modified Files
--------------
contrib/pageinspect/expected/brin.out | 13 ++++++-------
contrib/pageinspect/sql/brin.sql | 15 ++++++---------
2 files changed, 12 insertions(+), 16 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2024-04-17 16:32:41 pgsql: Cleanup parallel BRIN index build code
Previous Message Christoph Berg 2024-04-17 13:42:28 Re: pgsql: meson: Add initial version of meson based build system