Re: Weird test mixup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Weird test mixup
Date: 2024-04-05 02:19:26
Message-ID: Zg9frr5iIam3fhd7@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 18, 2024 at 10:04:45AM +0900, Michael Paquier wrote:
> Please find a patch to do exactly that, without touching the backend
> APIs. 0001 adds a new function call injection_points_local() that can
> be added on top of a SQL test to make it concurrent-safe. 0002 is the
> fix for the GIN tests.
>
> I am going to add an open item to not forget about all that.

It's been a couple of weeks since this has been sent, and this did not
get any reviews. I'd still be happy with the simplicity of a single
injection_points_local() that can be used to link all the injection
points created in a single process to it, discarding them once the
process exists with a shmem exit callback. And I don't really see an
argument to tweak the backend-side routines, as well. Comments and/or
objections?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-04-05 02:31:24 Re: IPC::Run::time[r|out] vs our TAP tests
Previous Message Michael Paquier 2024-04-05 02:12:18 Re: IPC::Run::time[r|out] vs our TAP tests