| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Weird test mixup |
| Date: | 2024-03-18 01:04:45 |
| Message-ID: | ZfeTLfltCTimaVbU@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 16, 2024 at 08:40:21AM +0900, Michael Paquier wrote:
> Linking all the points to a PID with a injection_points_attach_local()
> that switches a static flag while registering a before_shmem_exit() to
> do an automated cleanup sounds like the simplest approach to me based
> on what I'm reading on this thread.
Please find a patch to do exactly that, without touching the backend
APIs. 0001 adds a new function call injection_points_local() that can
be added on top of a SQL test to make it concurrent-safe. 0002 is the
fix for the GIN tests.
I am going to add an open item to not forget about all that.
Comments are welcome.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Introduce-runtime-conditions-in-module-injection_.patch | text/x-diff | 12.8 KB |
| v2-0002-Switch-GIN-tests-with-injection-points-to-be-conc.patch | text/x-diff | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2024-03-18 01:31:30 | Re: Autogenerate some wait events code and documentation |
| Previous Message | Richard Guo | 2024-03-18 00:39:25 | Re: Regarding the order of the header file includes |